Comments on: Multi-threading in Python

By: Brandon

Brandon — Tue, 09 Mar 2010 19:00:03 +0000

You know this is simply doing co-operative multitasking, not actual concurrency because of the GIL. To get the files all downloading at the same time, you need the multiprocessing module (or similar). See the video of David Beazley's talk at PyCon 2010.

By: arun

arun — Wed, 10 Feb 2010 19:56:55 +0000

awesome … probably the most detailed one so far

By: Salman

Salman — Thu, 21 Jan 2010 15:35:46 +0000

i guess u forgot “)” after
‘cons_thread = threading.Thread(target=consumer, args=(q, len(files))’
:P

By: bora

bora — Wed, 20 Jan 2010 19:50:18 +0000

Great tutorial. Thanks

By: Cooper Lees

Cooper Lees — Thu, 07 Jan 2010 05:19:34 +0000

Hey mate ! Thanks for the tutorial. Allowed me to get my head around threads again ! Hadn’t done it for years! Dam python makes it easier these days … /me remembers doing it in C++ …

By: kristall

kristall — Thu, 16 Jul 2009 02:53:42 +0000

Aloha,

also imho “get_files(files)” should “return finished”. And even its inside a def imho one should not use “file” as a variable since there is a builtin with that name.

Also ‘<’ does not show what it should.

kristall

By: kristall

kristall — Thu, 16 Jul 2009 01:18:11 +0000

Aloha,

in the run() parts it should be “self.url” instead of just “url”, or?

Else a very nice example, thanks for it.

greetinx
kristall

By: Jeff

Jeff — Fri, 29 May 2009 11:39:01 +0000

Denis – thanks for noticing that. I’ve updated the code.

By: denis

denis — Sat, 23 May 2009 22:24:50 +0000

Hi, thanks for this helpful tutorial. Please correct me if I’m wrong, but I believe you forgot calling the init :

class FileGetter(threading.Thread):
def __init__(self, url):
self.url = url
self.result = None
threading.Thread.__init__(self)

Thanks again BTW.

Best Regards,

Denis

By: Jeff

Jeff — Wed, 18 Feb 2009 20:52:09 +0000

Thanks for pointing out the bug. I don’t know how that went unnoticed for so long :).